Skip to content

Added AzLinux-dnf support for RedisPackageInstallation - #417

Closed
Rakesh (RakeshwarK) wants to merge 22 commits into
microsoft:mainfrom
RakeshwarK:Redis-Apt
Closed

Rakesh (RakeshwarK) wants to merge 22 commits into
microsoft:mainfrom
RakeshwarK:Redis-Apt

Conversation

@RakeshwarK

Copy link
Copy Markdown
Contributor

No description provided.

@RakeshwarK
Rakesh (RakeshwarK) marked this pull request as ready for review December 18, 2024 16:13
@RakeshwarK
Rakesh (RakeshwarK) marked this pull request as draft December 18, 2024 16:38
Comment thread src/VirtualClient/VirtualClient.Dependencies/RedisPackageInstallation.cs Outdated
}
},
{
"Type": "WgetPackageInstallation",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the changes in ubuntu?

@RakeshwarK Rakesh (RakeshwarK) Dec 19, 2024 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some issue with Redis, entering protected mode in ubuntu even without these changes, but the changes were running fine on AZ Linux.


}

private async Task InstallOnAzLinuxAsync(EventContext telemetryContext, CancellationToken cancellationToken)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried tdnf?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tdnf also works, is it preferred!?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on AzLinux yes, on RHEL still use dnf. You don;t have to change it right now, you could add a comment that tdnf also works. I heard AzLinux eventually wants to move to tdnf entirely


}

private async Task InstallOnAzLinuxAsync(EventContext telemetryContext, CancellationToken cancellationToken)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this would also work on RHEL/Fedora distros?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I haven't tested these cases. Should I also include RHEL/Fedora distros?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, Redis is important enough that we need more than ubuntu and AzLinux

@RakeshwarK
Rakesh (RakeshwarK) deleted the Redis-Apt branch January 7, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants